Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pyup or remove its badge from README.rst #12

Closed
s-weigand opened this issue Dec 3, 2018 · 4 comments
Closed

Use pyup or remove its badge from README.rst #12

s-weigand opened this issue Dec 3, 2018 · 4 comments

Comments

@s-weigand
Copy link
Contributor

At the moment a broken pyup badge is in the README.rst, which is a not too pretty artifact from the coociecutter template. The solution for this would to eigther drop the badge or start using pyup.

Pros and Cons on using pyup:
Pros:

  • pyup makes automated PRs when new versions of dependencies are released (automated testing due to the CIs, which garantees functionality new versions of dependencies)

Cons:

  • can be "spammy" if many updates of dependencies are released
  • will lead to merge conficts, with its own PRs, if ignored too long

PS.: Pyup only triggers on fixed versions (i.e.: pytest==3.0.5) not on minimum requirements (i.e.: pytest>=3.0.5), so by convention this should only affect requirements_dev.txt since it is bad practice to fix versions in the setup.py

@s-weigand
Copy link
Contributor Author

This should be decided on before #10 so the broken badge won't be shown on PyPi.

@oz123
Copy link
Owner

oz123 commented Dec 4, 2018

Can you make a PR for this?

@s-weigand
Copy link
Contributor Author

Sure, you just need to register the project at pyup and I will make a PR with fixed versions in the requirements_dev.txt

@oz123
Copy link
Owner

oz123 commented Dec 12, 2018

done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants