Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed dependency versions so pyup will work #16

Merged
merged 2 commits into from Jan 29, 2019

Conversation

s-weigand
Copy link
Contributor

Sorry for the delay, but here is the PR promissed in #12 .
With this the PRs from pyup will indicate if updates from tox or pytest, will break the plugin.

@coveralls
Copy link

coveralls commented Jan 29, 2019

Pull Request Test Coverage Report for Build 30

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 28: 0.0%
Covered Lines: 291
Relevant Lines: 291

💛 - Coveralls

@s-weigand
Copy link
Contributor Author

The failing of the tests was due to our own tests using the caplog fixture (to capture printing), which was introduced to pytest in version 3.4.
But this shouldn't compromice the fuctionality since it's just a dev-tool, so i guess there is no need to set a min version of pytest in the setup.py.

Copy link
Owner

@oz123 oz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@oz123 oz123 merged commit b47ea33 into oz123:master Jan 29, 2019
@s-weigand s-weigand deleted the pyup-fixed-dependency-versions branch February 3, 2019 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants