Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement TLS version of fixture #30

Merged
merged 11 commits into from
Apr 9, 2019

Conversation

s-weigand
Copy link
Contributor

This PR implements a second fixture ftpserver_TLS, which is a TLS encryped version of the fixture.
Other changes are:

  • introduced the possibility to configure the scope of the fixtures
  • renamed BaseMPFTPServer to FunctionalityWrapper
  • refacored the structure of the code
  • updated setup.py to reflect current state of the plugin and hopefully render properly on PyPi
  • added more discriptions to HISTORY.rst
  • extended and improved documentation

@coveralls
Copy link

coveralls commented Mar 31, 2019

Pull Request Test Coverage Report for Build 82

  • 294 of 294 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 78: 0.0%
Covered Lines: 356
Relevant Lines: 356

💛 - Coveralls

Copy link
Owner

@oz123 oz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@s-weigand thank you for this huge effort. I am sorry it took me a while to review this.

docs/usage.rst Show resolved Hide resolved
@oz123 oz123 merged commit f5ec3d3 into oz123:master Apr 9, 2019
@s-weigand s-weigand deleted the implement-ftpserver_tls branch May 26, 2019 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants