Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a release for legacy python versions #50

Merged
merged 3 commits into from
Jul 1, 2019

Conversation

s-weigand
Copy link
Contributor

Hi Oz,
since the merge of PR #49 the tests are broken, because pytests>=5. 0.0 dropped support for legacy python versions (namely in this case py27 and py34).
This PR will pass the tests and should be the release candidate for a minor version (i.e. 0. 6.0), so please bump the version after the merge.
To get up to date again, I will make a PR that drops all legacy code and make a note for users to use this release if they need support for older python versions.

P.S.: If you also stopped using py27 we could also upgrade bumpversion to bump2version, which is a fork of bumpversion which is still maintained and supports python 2+3.

@coveralls
Copy link

coveralls commented Jul 1, 2019

Pull Request Test Coverage Report for Build 148

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 100.0%

Totals Coverage Status
Change from base Build 147: 0.4%
Covered Lines: 356
Relevant Lines: 356

💛 - Coveralls

@s-weigand
Copy link
Contributor Author

s-weigand commented Jul 1, 2019

Well the osx-py34 test is apparently failing, because anaconda isn't providing py34 for osx, anymore.
So it could be ignored, since with my next PR, py27 and py34 will be dropped anyway.

@oz123 oz123 merged commit 9f091a0 into oz123:master Jul 1, 2019
@s-weigand s-weigand deleted the legacy-py-release branch September 23, 2019 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants