Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement create file shortcut #5

Merged
merged 8 commits into from
Sep 1, 2022
Merged

Conversation

gozeloglu
Copy link
Contributor

@gozeloglu gozeloglu commented Jul 23, 2022

Current problem: The tree is not updated after creating a new file. We don't see the newly created file. I am open to getting help with this problem.

Signed-off-by: Gökhan Özeloğlu gokhan.ozeloglu@deliveryhero.com

* Related to ozansz#2.

Signed-off-by: Gökhan Özeloğlu <gokhan.ozeloglu@deliveryhero.com>
@gozeloglu gozeloglu changed the title WIP | Implement create file shortcut Implement create file shortcut Aug 1, 2022
@gozeloglu gozeloglu marked this pull request as ready for review August 1, 2022 19:27
@gozeloglu
Copy link
Contributor Author

Hi @ozansz. Sorry for being late to make PR ready for review. As I mentioned above, there is a problem. I thought I was able to solve it, but, couldn't understand the reason. If you have a guess about the bug, I'd like to hear it.

@ozansz
Copy link
Owner

ozansz commented Aug 2, 2022

Hi @ozansz. Sorry for being late to make PR ready for review. As I mentioned above, there is a problem. I thought I was able to solve it, but, couldn't understand the reason. If you have a guess about the bug, I'd like to hear it.

Hi, thanks for the PR! I will check and try to find why the tree is not updated

@ozansz
Copy link
Owner

ozansz commented Aug 31, 2022

I've spotted the issue: the function createNewFile was not actually creating a *Node inside the virtual file tree, so after the UI update, the tree was the same. I also done some minor updates on your branch, I think it works now. Feel free to add any other updates to the code 😁

Gökhan Özeloğlu added 2 commits September 1, 2022 08:49
* Renamed finfo -> fInfo

Signed-off-by: Gökhan Özeloğlu <gokhan.ozeloglu@deliveryhero.com>
@gozeloglu
Copy link
Contributor Author

I've spotted the issue: the function createNewFile was not actually creating a *Node inside the virtual file tree, so after the UI update, the tree was the same. I also done some minor updates on your branch, I think it works now. Feel free to add any other updates to the code 😁

Thank you for your help 💯 I tried and it works on my machine. In the last commit, I just renamed a variable. It seems the PR is ready to merge.

@ozansz ozansz merged commit dfd7fe9 into ozansz:main Sep 1, 2022
@gozeloglu gozeloglu deleted the create-shortcut-n branch September 1, 2022 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants