Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace print calls by logger calls #6

Open
unkindypie opened this issue Aug 22, 2023 · 0 comments
Open

Replace print calls by logger calls #6

unkindypie opened this issue Aug 22, 2023 · 0 comments

Comments

@unkindypie
Copy link

unkindypie commented Aug 22, 2023

When during handing of a notification an error occures, it's printed using print function. As the library has built-in logger class which can be extended and injected by client code, it's better to replace print calls with logger calls. It will allow client-side loggers capture exceptions inside notification handlers. Also, it will be helpful if Mediator class will also pass exception stack trace to the logger.
Reference to the file with an issue:
https://github.com/ozgurkara/pydiator-core/blob/5aec2f61c8489210135dc69f35ed5f1a600551a0/pydiator_core/mediatr.py#L53C1-L54C1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant