Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds shutdown hook #11

Merged
merged 1 commit into from
Apr 27, 2020
Merged

Adds shutdown hook #11

merged 1 commit into from
Apr 27, 2020

Conversation

netodevel
Copy link

@netodevel netodevel commented Apr 11, 2020

Hi, I had problems running redis-embedded with spring boot in a jenkins pipeline.

Sometimes the redis stop is not efficient leaving the port stuck in the pipeline as a result of which the next job fails.

I added a hook for when the process that started the redis-embedded stops then it forces the redis to stop.

I was unable to create an automated test for this, if anyone has any suggestions I would appreciate it.

when run together with spring it stops the redis in the sequence that spring-context stops.

@codecov-io
Copy link

Codecov Report

Merging #11 into master will increase coverage by 0.51%.
The diff coverage is 85.71%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #11      +/-   ##
============================================
+ Coverage     72.29%   72.81%   +0.51%     
- Complexity      113      116       +3     
============================================
  Files            20       20              
  Lines           509      515       +6     
  Branches         38       38              
============================================
+ Hits            368      375       +7     
  Misses          118      118              
+ Partials         23       22       -1     
Impacted Files Coverage Δ Complexity Δ
...ain/java/redis/embedded/AbstractRedisInstance.java 86.95% <85.71%> (+2.82%) 14.00 <2.00> (+3.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aeef6be...03b5b3f. Read the comment docs.

@netodevel
Copy link
Author

@robertotru, any feedback on this pr?

@robertotru robertotru merged commit 6bb0419 into ozimov:master Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants