refactor code to increase coverage

Signed-off-by: Hakan <ozler.hakan@gmail.com>
ozlerhakan · May 25, 2020 · fd7693d · fd7693d
1 parent a8385b3
commit fd7693d
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 28 deletions.
diff --git a/src/main/java/com/poiji/bind/mapping/PoijiNumberFormat.java b/src/main/java/com/poiji/bind/mapping/PoijiNumberFormat.java
@@ -23,10 +23,6 @@ public String getNumberFormatAt(short fmtId) {
         return numberFormats.get(fmtId);
     }
 
-    public int size() {
-        return numberFormats.size();
-    }
-
     void overrideExcelNumberFormats(final StylesTable styles) {
         for (Short fmtId : numberFormats.keySet()) {
             String format = numberFormats.get(fmtId);

diff --git a/src/main/java/com/poiji/bind/mapping/PoijiPropertyHelper.java b/src/main/java/com/poiji/bind/mapping/PoijiPropertyHelper.java
@@ -8,10 +8,7 @@
 /**
  * Created by hakan on 24.05.2020
  */
-public class PoijiPropertyHelper {
-
-    private PoijiPropertyHelper() {
-    }
+public final class PoijiPropertyHelper {
 
     public static HSSFPropertyFile createPoijiPropertyFile(File file, PoijiOptions options) {
         return new HSSFPropertyFile(file, options);

diff --git a/src/main/java/com/poiji/bind/mapping/XSSFUnmarshaller.java b/src/main/java/com/poiji/bind/mapping/XSSFUnmarshaller.java
@@ -1,7 +1,6 @@
 package com.poiji.bind.mapping;
 
 import com.poiji.bind.Unmarshaller;
-import com.poiji.exception.LimitCrossedException;
 import com.poiji.exception.PoijiException;
 import com.poiji.option.PoijiOptions;
 import org.apache.poi.openxml4j.exceptions.OpenXML4JException;
@@ -116,10 +115,8 @@ private <T> void processSheet(StylesTable styles,
                     options);
             reader.setContentHandler(contentHandler);
             reader.parse(sheetSource);
-        } catch (LimitCrossedException e) {
-            IOUtils.closeQuietly(sheetInputStream);
-            // swallowing the exception for good :)
         } catch (SAXException | IOException e) {
+            IOUtils.closeQuietly(sheetInputStream);
             throw new PoijiException("Problem occurred while reading data", e);
         }
     }

diff --git a/src/main/java/com/poiji/exception/LimitCrossedException.java b/src/main/java/com/poiji/exception/LimitCrossedException.java
diff --git a/src/main/java/com/poiji/parser/BigDecimalParser.java b/src/main/java/com/poiji/parser/BigDecimalParser.java
@@ -14,13 +14,9 @@ public class BigDecimalParser implements Parser<BigDecimal> {
 
     private DecimalFormat getDecimalFormatInstance() {
         NumberFormat numberFormat = NumberFormat.getInstance();
-        if (numberFormat instanceof DecimalFormat) {
-            DecimalFormat decimalFormat = (DecimalFormat) numberFormat;
-            decimalFormat.setParseBigDecimal(true);
-            return decimalFormat;
-        } else {
-            throw new IllegalStateException(numberFormat.getClass().getName());
-        }
+        DecimalFormat decimalFormat = (DecimalFormat) numberFormat;
+        decimalFormat.setParseBigDecimal(true);
+        return decimalFormat;
     }
 
     @Override