Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving #129

Closed
wants to merge 17 commits into from
Closed

Saving #129

wants to merge 17 commits into from

Conversation

vaa25
Copy link
Contributor

@vaa25 vaa25 commented Feb 2, 2020

  • ExcelCellRange not supported in writing.
  • ExcelCellName has new parameter 'order'. It used to set column number for field.
  • Xlsx support huge data.
  • support thread-safe saving
  • Fix Boolean, byte, Byte, short, Short casting
  • Add customizing of CellCasting (field to cell casting for toExcel())

@coveralls
Copy link

coveralls commented Feb 2, 2020

Coverage Status

Coverage decreased (-0.9%) to 91.117% when pulling 7d346c0 on vaa25:saving into 12283d9 on ozlerhakan:2.6.0.

@vaa25 vaa25 requested a review from ozlerhakan February 2, 2020 21:12
@ozlerhakan
Copy link
Owner

hey @vaa25 , thanks for the changes, we need to improve the coverage first for the pr

@vaa25
Copy link
Contributor Author

vaa25 commented Feb 8, 2020

@ozlerhakan feature looks completed. Review please.

pom.xml Outdated Show resolved Hide resolved
@vaa25 vaa25 mentioned this pull request Feb 9, 2020
@ozlerhakan
Copy link
Owner

thank you for your effort @vaa25 , since this is a big change for poiji, I need to look at them closely however, currently I don't have time to do that :/ Let's keep it here for now

@vaa25
Copy link
Contributor Author

vaa25 commented Apr 19, 2020

moved to https://github.com/vaa25/poiji

@vaa25 vaa25 closed this Apr 19, 2020
@vaa25 vaa25 deleted the saving branch April 19, 2020 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants