Replaced Class#newInstance method with Constructor#newInstance method #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Class#newInstance method creates an instance but by-passes some checked exceptions (NoSuchMethod and InvocationTargetException) which could otherwise be caught by the compiler.
This PR also removes the method Field#isAccessible() and preemptively calls the Field#setAccessible(true) method since all fields created from Class#getDeclaredFields() have the accessible flag set to false.
The Class#newInstance method and the Field#isAccessible() are also deprecated in java 9