-
-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added methods to read excel properties from excel files #154
Conversation
Currently missing:
|
* Set the locale to en-US for tests, as tests break on non en-US machines
* Added file for built-in excel property names
Hi @breucode , thanks for the changes! at first glance, we need to improve the code coverage a bit more :) |
Hi @ozlerhakan :). As far as I can see, the only new untested code are private constructors and exception handling. Should we add testing for exception handling to Poiji? If we do so, we could add a mocking framework for non-static calls. However, a lot of calls are static (e.g. What would you say @ozlerhakan ? |
I think we need to refrain ourselves to use/create static methods. |
I agree, but I don't see a way to replace calls like OPCPackage.open(...), which come from an external library. |
I will look at it this weekend @breucode |
This PR enables the possibility to read excel properties (but only from XLSX files!).
Solves #151