Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added tests for casting and files #18

Merged
merged 1 commit into from
Nov 7, 2017
Merged

added tests for casting and files #18

merged 1 commit into from
Nov 7, 2017

Conversation

ghacupha
Copy link
Contributor

@ghacupha ghacupha commented Nov 6, 2017

At a small cost...
Had to change the Casting and Files classes from utility files to singletons

@coveralls
Copy link

Coverage Status

Coverage increased (+2.1%) to 85.833% when pulling d8b2e44 on ghacupha:master into 1661948 on ozlerhakan:master.

@ghacupha ghacupha mentioned this pull request Nov 6, 2017
Closed
@ozlerhakan ozlerhakan merged commit d8b2e44 into ozlerhakan:master Nov 7, 2017
@ozlerhakan
Copy link
Owner

Thank you @ghacupha, I have merged to the master, making these classes singleton is better for coverages indeed, static methods are evil :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ghacupha @coveralls @ozlerhakan