Added version 4.0.0-SNAPHOT #46
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ullPointerException occurring when in java 9/10 environment
…ullPointerException occurring when in java 9/10 environment
…en by lifecycle mapping plugin, there being no public version 4 release
|
The build is failing, I thought travis would start the build using the manually attached jars. Standby for further updates. I will try to change the position of the pom to see if their dependencies can be transitively resolved on travis. |
…an fetch from github repository
|
Yes you can close it. Sorry if I took long to reply. I have limited access
to the net. If 49 is the latest one then it should be fine, but use it in a
branch for a future release first.
Regards
Edwin
…On Thu, 2 Aug 2018, 23:00 Hakan Özler, ***@***.***> wrote:
Hi @ghacupha <https://github.com/ghacupha> ,
Thank your for your valuable work!, Should I close this PR in terms of #49
<#49> ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#46 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ATPyh49jK_y6e0nNNgBgBmPEgRR4nE0xks5uM1pVgaJpZM4Vq5Yk>
.
|
|
No worries @ghacupha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Okay so this is a bit out there, you might even want to do a several branch for this PR. What I do guarantee, is that it has been tested in java 10 environment, and all the tests ran successfully, and so did the maven package command. Except due to the range of changes, I elected to do an uber jar with all dependencies included.
I needed the code to run with java 10. I checked the current commits in poi repositories only to notice that they had fixed the ZipSecureFile problem, they were having with the library in java 9 environments.
Unfortunately that fix is slotted for version 4.0.0 currently tagged as 4.0.0-SNAPHOT. As you know they have not released the version 4, and I could not find their maven snapshot releases.
So here is what I did:
i) I downloaded the jars from the latest successful build from their jenkens CI
ii) I put then in the lib folder with LICENSE included to avoid legal suit and stuff
iii) I used the install plugin to install them to local repository using the life-cycle mapping plugin during initialization. This effectively makes the workflow platform independent.
iv) I then use the shade plugin to create the dependencies-included jar, whenever you call package command with the name poiji.
This was done with maven version 3.5.4 running on java version 10.0.2. Tomorrow I will try whether java 8 will still work. But for today, I find this useful for java 10 guys. Once the version 4 is publicly available we can remove that lib folder and the repository i added in the pom, and revert back to normal maven-managed dependencies. What do you think?