Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new change to read excel file by sheet name #77

Merged
merged 3 commits into from
Apr 14, 2019

Conversation

4sujittiwari
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Mar 13, 2019

Coverage Status

Coverage increased (+0.02%) to 87.5% when pulling e848ae0 on 4sujittiwari:1.19.2 into 351e497 on ozlerhakan:master.

@ozlerhakan
Copy link
Owner

Thanks @4sujittiwari ,I will look at the changes soon.

@ozlerhakan
Copy link
Owner

sorry @4sujittiwari , I haven't looked at it yet

@AdrienHorgnies
Copy link

AdrienHorgnies commented Apr 4, 2019

@4sujittiwari I gave a quick look at the PR. You've mixed spaces and tabs indentation. Could you indent with spaces everywhere, please ? That would make the code easier to read on Github.

@4sujittiwari
Copy link
Contributor Author

@4sujittiwari I gave a quick look at the PR. You've mixed spaces and tabs indentation. Could you indent with spaces everywhere, please ? That would make the code easier to read on Github.

Sure @AdrienHorgnies ...

@ozlerhakan ozlerhakan merged commit e848ae0 into ozlerhakan:master Apr 14, 2019
@ozlerhakan
Copy link
Owner

thanks @4sujittiwari , merged!

@4sujittiwari 4sujittiwari deleted the 1.19.2 branch April 17, 2019 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants