Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement] Improve layout for config screen #31

Closed
Herbert-Hotz opened this issue Feb 17, 2018 · 5 comments
Closed

[enhancement] Improve layout for config screen #31

Herbert-Hotz opened this issue Feb 17, 2018 · 5 comments

Comments

@Herbert-Hotz
Copy link

Herbert-Hotz commented Feb 17, 2018

Hi,
I think that the config screen needs a small improvement: Currently the editor element overlaps on top
with title element (Chrome browser, others not tested).

ui/src/scss/styles.scss

#config-editor {
  position: absolute;
  bottom: 30px;
  top: 140px;
  right: 15px;
  left: 15px;
  width: auto;
  box-shadow: 0 2px 5px 0 rgba(0, 0, 0, 0.16), 0 2px 10px 0 rgba(0, 0, 0, 0.12);
}

Recommended change: top: 170px

@Herbert-Hotz Herbert-Hotz changed the title Improve layout for config screen [enhancement] Improve layout for config screen Feb 17, 2018
@oznu
Copy link
Member

oznu commented Feb 17, 2018

Hi @Herbert-Hotz,

Thanks for raising this. Would you be able to upload a screenshot so I can see what's going on?

@Herbert-Hotz
Copy link
Author

Herbert-Hotz commented Feb 17, 2018

BTW: Windows 10 / Google Chrome is up to date Version 64.0.3282.167 (Official Build) (64-bit)

Here comes a screenshot:

2018-02-17 15_37_59-homebridge

@Herbert-Hotz
Copy link
Author

I made a test on a another Windows 10 host with a different Google Chrome version and everything looked fine:
Google Chrome is up to date
Version 65.0.3325.73 (Official Build) beta (64-bit)

Strange enough!! Please do NOT invest too much time - it might be a browser issue.

Thanks nevertheless for taking care.

@oznu oznu closed this as completed in d5631ff Feb 18, 2018
@oznu
Copy link
Member

oznu commented Feb 18, 2018

Hi @Herbert-Hotz,

This should be fixed in 2.6.3. I have changed the config editor to use flexbox instead of position: absolute; to stretch the element to the bottom of the page. The editors position is now relative to the title element and should never be able to overlap.

I was not able to replicate this on any of the browsers I test on, so please let me know if this fixed it for you.

@Herbert-Hotz
Copy link
Author

Hi @oznu,

Thanks for your super fast response and fix! Well done - works great now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants