Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations for Accessory state #342

Closed
grzegorz914 opened this issue Aug 7, 2019 · 36 comments
Closed

Translations for Accessory state #342

grzegorz914 opened this issue Aug 7, 2019 · 36 comments

Comments

@grzegorz914
Copy link
Contributor

Hi,

It would be nice add translations for accessory state, now we have only EN.

Thanks

@oznu
Copy link
Member

oznu commented Aug 7, 2019

Good idea. There shouldn't be too many new words to translate.

@mafyata
Copy link

mafyata commented Aug 7, 2019

We will translate it fast. I translated hoobs BG language for 1 hour.

@oznu
Copy link
Member

oznu commented Aug 8, 2019

I've added support for this and created placeholders for all the keys that need translating in each language file.

https://github.com/oznu/homebridge-config-ui-x/blob/master/ui/src/i18n/en.json#L17-L39

For details on how to get a development environment setup so you can preview your translations in-app see https://github.com/oznu/homebridge-config-ui-x/blob/master/CONTRIBUTING.md.

@oznu
Copy link
Member

oznu commented Aug 8, 2019

    "accessories.control.label_on": "On",
    "accessories.control.label_off": "Off",
    "accessories.control.label_open": "Open",
    "accessories.control.label_closed": "Closed",
    "accessories.control.label_opening": "Opening",
    "accessories.control.label_closing": "Closing",
    "accessories.control.label_stopped": "Stopped",
    "accessories.control.label_locked": "Locked",
    "accessories.control.label_unlocked": "Unlocked",
    "accessories.control.label_jammed": "Jammed",
    "accessories.control.label_unknown": "Unknown",
    "accessories.control.label_triggered": "Triggered",
    "accessories.control.label_heat": "Heat",
    "accessories.control.label_cool": "Cool",
    "accessories.control.label_auto": "Auto",
    "accessories.control.label_rotation_speed": "Rotation Speed",
    "accessories.control.label_brightness": "Brightness",
    "accessories.control.label_set_to": "Set to",
    "accessories.control.label_target": "Target",
    "accessories.control.label_target_temperature": "Target Temperature",
    "accessories.control.label_fan": "Fan",
    "accessories.control.label_light": "Light",
    "accessories.control.not_supported": "Not Supported",

@grzegorz914
Copy link
Contributor Author

Hi,

updated to beta22 and Accessory - Thermostat Mode off are not translated.

Thanks

@Caribsky
Copy link
Contributor

Caribsky commented Aug 8, 2019

Same problem with Thermostat.
Aslo Homebridge restart page not translated too.
Снимок экрана 2019-08-08 в 16 36 20

@grzegorz914
Copy link
Contributor Author

Also „Default Room” need to be translated.

@oznu
Copy link
Member

oznu commented Aug 8, 2019

I've fixed the thermostat Off label and added a key for "Default Room".

@Caribsky
Copy link
Contributor

Caribsky commented Aug 8, 2019

@oznu
By the way… Thermostat window with translation too small
Снимок экрана 2019-08-08 в 16 36 10

@oznu
Copy link
Member

oznu commented Aug 8, 2019

@Caribsky - I can stack them vertically.

image

@Caribsky
Copy link
Contributor

Caribsky commented Aug 8, 2019

I like this layout. Looks like as on iPhone.
Also I need fix translation for thermostat.

@oznu
Copy link
Member

oznu commented Aug 8, 2019

The beta has been updated with your pull requests and the other changes made.

@Caribsky
Copy link
Contributor

Caribsky commented Aug 8, 2019

@oznu
I don't see any accessories and rooms after this update.
cache deleted in Safari.. :(

@Caribsky
Copy link
Contributor

Caribsky commented Aug 8, 2019

Sorry, @oznu
Looks like it's my local problem with Safari.
All OK in Firefox.

@oznu
Copy link
Member

oznu commented Aug 8, 2019

You had me worried. I'll check out Safari tomorrow to make sure it's all ok.

@grzegorz914
Copy link
Contributor Author

grzegorz914 commented Aug 8, 2019

Im on safari macOSX Catalina b5, all is displayed OK, except state of thermostat, which is not displayed on accessory.
Zrzut ekranu 2019-08-8 o 19 26 56

@mafyata
Copy link

mafyata commented Aug 8, 2019

Bulgarian language translation. It is in zip because I can't upload json file here.

bg.zip

@tooh
Copy link
Contributor

tooh commented Aug 9, 2019

I'm running - homebridge-config-ui-x v4.5.2 - on EN
Accessories correct in menu spelled wrong in Homebridge accessories page

Homebridge Accessores

@oznu
Copy link
Member

oznu commented Aug 9, 2019

Hi @tooh,

The only instance of the word Accessores is in the NL translation?

https://github.com/oznu/homebridge-config-ui-x/search?q=Accessores&unscoped_q=Accessores

@tooh
Copy link
Contributor

tooh commented Aug 9, 2019

Hm strange was not aware that it uses Nl as language. But you’re right.

Translation should be:

accessoires

@Caribsky
Copy link
Contributor

Caribsky commented Aug 9, 2019

Hi @oznu,
Could you please update beta.. i can't fetch last merged translation fix in ru.json.
Thanks

Also, regarding Thermostat window. The accessory box start dragging when click on Thermostat in Firefox (mac os), please see screenshot below.

Снимок экрана 2019-08-09 в 16 10 01

@oznu
Copy link
Member

oznu commented Aug 9, 2019

@Caribsky, I'll update the beta soon and let you know.

Regarding the thermostat window, you need to start moving your mouse within 350 ms otherwise it detects a "long press" and opens up the modal. I've just tested this on the latest versions of Firefox, Safari and Chrome on macOS.

@oznu
Copy link
Member

oznu commented Aug 9, 2019

@tooh, updated, thanks.

@Caribsky
Copy link
Contributor

Caribsky commented Aug 9, 2019

@oznu
It's really strange.. I have last stable versions of Firefox, Safari and Chrome. Only in Firefox appeared this bug and it's doesn't depend from delay of start moving mouse, after 1 sec or 10 sec.
Just tried to test it on other Windows computer.. same problem with Firefox. :(

@oznu
Copy link
Member

oznu commented Aug 9, 2019

@Caribsky, i think i misunderstood the issue you described. I thought you were saying when you were trying to move the tiles, the modal was showing, but you mean when you are trying to open the modal, the tile starts moving?

That I can replicate in firefox.

image

@Caribsky
Copy link
Contributor

Caribsky commented Aug 9, 2019

@oznu, in other words ... the tile starts following the cursor after showing the modal window.
ps. sorry for my english

@oznu
Copy link
Member

oznu commented Aug 9, 2019

I can't figure this one out right now @Caribsky, I'll try again later, as a work around you can toggle the layout lock:

image

@Caribsky
Copy link
Contributor

Caribsky commented Aug 9, 2019

Thanks, @oznu
Toggle the layout lock is good idea, it's helped.

@oznu
Copy link
Member

oznu commented Aug 10, 2019

@Caribsky, I fixed the Firefox modal and drag issue in the latest beta.

@Caribsky
Copy link
Contributor

@Caribsky, I fixed the Firefox modal and drag issue in the latest beta.

Works good!
Thank you, @oznu!

@grzegorz914
Copy link
Contributor Author

One word still not translated: "End Process"
IMG_0062

@oznu
Copy link
Member

oznu commented Aug 10, 2019

Thanks @grzegorz914, that bit of text is is sent directly from the server as a debug message, so it doesn't get translated. I don't have any plans to add internationalisation to the server side any time soon (this includes all logs, or error / debug messages sent from the server like the one above).

@grzegorz914
Copy link
Contributor Author

@oznu
ok its clear.

@oznu
Copy link
Member

oznu commented Aug 10, 2019

I just pushed up a new beta, with dark mode off-state tiles. I'm not sure how to handle on-state tiles in dark mode yet, I'll probably wait until I can see how iOS 13 dark mode does it.

@oznu
Copy link
Member

oznu commented Aug 10, 2019

It broke light mode on-state of course, should have tested, fixing it now.

@oznu
Copy link
Member

oznu commented Aug 10, 2019

Thanks everyone for your help one this one.

@oznu oznu closed this as completed Aug 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants