-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config-ui-x breaks homebridge-apple-tv plugin #75
Comments
I've setup this plugin and cannot replicate the issue.
My config: {
"bridge": {
"username": "0E:E7:33:3A:A0:A7",
"port": 51827,
"pin": "446-01-911",
"name": "Homebridge on Mac"
},
"platforms": [
{
"platform": "config",
"name": "Config",
"port": 8080,
"sudo": false,
"auth": false
},
{
"platform": "AppleTV",
"name": "Apple TV",
"devices": [
{
"id": "lounge",
"name": "Lounge Apple TV",
"credentials": "xxxxxxxxxx"
}
],
"accessories": [
{
"deviceID": "lounge",
"name": "Up",
"command": "up"
},
{
"deviceID": "lounge",
"name": "Down",
"command": "down"
}
]
}
],
"accessories": []
}
|
For me the AppleTV plugin doesn't discover any Apple TV devices until I disable config-ui-x from my config then the AppleTV plugin works. Heres my config:
Heres the bit I need to remove:
|
Can you post the homebridge logs from startup? Knowing the order that the plugins get loaded in on your system might be helpful. Are you running on a Raspberry Pi 3? |
Yes, it's a Pi3 Heres the startup when I add the config-ui-x bit at the very end:
Edit: and for good measure heres without config-ui-x:
Edit2: Btw I did try changing the order and put the apple-tv plugin first and last but it doesn't seem to do anything. |
My guess is the single threaded node.js runtime is being blocked by the loading of this plugin at startup, so the Homebridge-config-ui-x pulls in quite a few dependencies on startup using the standard
I have published a test version of this plugin which would might want to try out:
Without making any changes to your config the minor changes I made around dependency load order probably won't make a difference. What you can do though is adjust your config slightly: Change the
This will tell |
Yeah, I noticed that config-ui-x increases the load time a lot. It is a RasPi3 in my case and yes, this change makes my homebridge setup discover the Apple TV with config-ui-x enabled. In general the startup of Homebridge is much faster now, before config-ui-x would always warn me that the server takes a long time to start ^^ |
Great, thanks for testing. I'm going to run this test version for the next few days to make sure everything is ok before publishing it. Let me know if you encounter any quirks. If it works well I might make this the default behaviour in the next major version. |
This multithreading thing sounds great. |
Yeah, and it seems to work great, my homebridge server has been running for the last few hours with me playing around in config-ui-x, updating plugins etc. The whole homebridge system seems to be a lot snappier - don't know if thats possible. |
I've pushed up a new version to the
Before restarting homebridge change |
works too! |
Thanks. I'll try this on a single core raspberry pi some time in the next few days. If the performance is still acceptable I will push this change out to everyone. People using the oznu/homebridge docker container have been running this plugin as a separate process since I took over the project, so I'm fairly comfortable rolling this out to all users. |
This has been published to the https://github.com/oznu/homebridge-config-ui-x/blob/master/CHANGELOG.md#350-2018-04-12 |
I have made a fresh install of Homebridge with AppleTV plugin and Config-ui-x and the latter is still preventing the appletv plugin from discovering the apple tv, so why is this ticket closed? |
Ask this at apple tv plugin’s page. |
already asked: lprhodes/homebridge-apple-tv#9 (comment) |
Hi,
it seems this plugin is causing issues in another homebridge plugin for some reason:
lprhodes/homebridge-apple-tv#9
The text was updated successfully, but these errors were encountered: