add "latestReleaseDate" property to HomebrigePlugin #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a search returns multiple similar looking plugins, display the latestReleaseDate might help people choose which plugin to use add package-lock.json for server side and ui because this file is auto-generated by npm, thus no need to include it in version control
unignore npm lock files add *ngIf="!plugin.installedVersion" to latestReleaseDate in ui
|
Thanks for the PR. Are you able to update the plugin.service.ts file to only include the relevant changes - not the formatting updates? |
in file 'src/modules/plugins/plugins.service.ts'
move label 'Latest Release Date:' inside {{}} so that *ngIf can control
when to show this label
|
Would this be okay? The reformatting might have been caused by a vscode extension. But I have disabled format on save, yet the editor still reformats the code on save. Quite odd. |
|
Looking good now. Thanks. I'll merge this soon. |
add '"editor.formatOnSave": true' to '.vscode/settings.json' this file seems to be auto-generated
|
I adjusted the display of this:
|
|
This is currently in beta, and will be release as part of v4.6.0. You can install the beta now by running: |
|
Thank you! Sent with GitHawk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a search returns multiple similar looking plugins, display the
latestReleaseDate might help people choose which plugin to use
add *ngIf="!plugin.installedVersion" to latestReleaseDate in ui
Known Issue
Currently, latestReleaseDate would also be shown for installed plugins, but package.json of installed plugins doesn't have "date" property
Ideally we could fetch this from npmjs.com registry, the response json has "date" property for each plugin