Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CircularReveal does not have any effect running on Android 5.1 #31

Closed
tounaobun opened this issue May 28, 2015 · 15 comments
Closed

CircularReveal does not have any effect running on Android 5.1 #31

tounaobun opened this issue May 28, 2015 · 15 comments

Comments

@tounaobun
Copy link

It is weird that running on Android 5.1,ViewAnimationUtils.createCircularReveal does not have any animation starting.

@ozodrukh
Copy link
Owner

well, it works on my phone furthermore on Genymotion emulator too, can you share any piece of code

@yhsj0919
Copy link

device: mi2
system: miui6,android5.0.2
Have the same problem

@ozodrukh
Copy link
Owner

Guys, can you share code that you are running?

@yhsj0919
Copy link

you can see that it's a old version . you can replace the new code https://github.com/yhsj0919/YHUtils/tree/master/YHUI

@marbat87
Copy link
Contributor

I confirm that it doens't work on Android 5.0 or above (tested on 5.0 and 5.1.1).

My code is the following:

                rootView.findViewById(R.id.consegnati_view).setVisibility(View.INVISIBLE);
                View myView = rootView.findViewById(R.id.choose_view);
                myView.setVisibility(View.VISIBLE);
                // get the center for the clipping circle
                int cx = myView.getRight();
                int cy = myView.getTop();
                // get the final radius for the clipping circle
                int finalRadius = Math.max(myView.getWidth(), myView.getHeight());
                SupportAnimator animator =
                        ViewAnimationUtils.createCircularReveal(myView, cx, cy, 0, finalRadius);
                animator.setInterpolator(new AccelerateDecelerateInterpolator());
                animator.setDuration(CIRCLE_DURATION);
                animator.start();

The purpose is to hide "consegnati_view" and reveal the "choose_view" from the top right corner. They're inside the same parent "io.codetail.widget.RevealFrameLayout" in my xml.

It works perfectly on Android versions below 5.0

@ozodrukh
Copy link
Owner

marbat87, hm interesting remark, i will try to figure out today

@tounaobun
Copy link
Author

@ozodrukh I think the code I wrote is correct,because it runs successfully below Android L.Maybe it is a problem of compatibility.Hope you can fix it.Thanks.:-)

@ozodrukh
Copy link
Owner

Well actually I made a commit relative to this issue, and some sample, cab
you check out them, if everything is fine I will made release it
On May 30, 2015 2:55 PM, "Benson" notifications@github.com wrote:

@ozodrukh https://github.com/ozodrukh I think the code I wrote is
correct,because it runs successfully below Android L.Maybe it is a problem
of compatibility.Hope you can fix it.Thanks.:-)


Reply to this email directly or view it on GitHub
#31 (comment)
.

@efemoney
Copy link

efemoney commented Jun 2, 2015

I'll like to add that it doesn't work for me too 5.0 and 5.1 but works pre-L.

I don't know how to get the fix from github thought.Could you help me

@ozodrukh
Copy link
Owner

ozodrukh commented Jun 2, 2015

Can you clone repository and check out new version (it is not released in jitpack)

@y3seker
Copy link

y3seker commented Jun 3, 2015

I can confirm that last changes are working on 5.1.1, thanks for it.

@ozodrukh
Copy link
Owner

ozodrukh commented Jun 3, 2015

Great 👍
i'm closing this issue for now, if something happen please re-open it and provide some more information
will wait for 2 day and will release new version

@ozodrukh ozodrukh closed this as completed Jun 3, 2015
@aashreys
Copy link

aashreys commented Jun 6, 2015

When will the update be released?

@devspacenine
Copy link

Can confirm that version 1.1.1 works on Android 5.1.1. @aashrey99 it is now in jitpack

@ozodrukh
Copy link
Owner

ozodrukh commented Jun 7, 2015

Thanks guys for help 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants