Add join_template action plugin with go_panic template #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadimalekseev
approved these changes
Aug 8, 2022
ansakharov
reviewed
Aug 8, 2022
| @@ -0,0 +1,96 @@ | |||
| package join_go_panic | |||
There was a problem hiding this comment.
You decided do separate plugins for go, java etc? It can be one plugin: join_panic with different modes. Will it be too verbose?
There was a problem hiding this comment.
Yes, I think it's a good idea to create one plugin for all such cases, where another languages patterns could be added as new options. So I propose an implementation of join_template plugin.
vano144
approved these changes
Aug 11, 2022
HeadHunter483
force-pushed
the
151-join-go-panic-plugin
branch
from
b3445c7
to
dc08c10
Compare
HeadHunter483
force-pushed
the
151-join-go-panic-plugin
branch
from
dc08c10
to
fac665c
Compare
HeadHunter483
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #151