New metric holder #411
Merged
New metric holder #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
July 6, 2023 20:29
# Conflicts: # metric/controller.go
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #411 +/- ##
==========================================
+ Coverage 70.16% 70.24% +0.07%
==========================================
Files 112 116 +4
Lines 11838 11845 +7
==========================================
+ Hits 8306 8320 +14
+ Misses 3024 3023 -1
+ Partials 508 502 -6 ☔ View full report in Codecov by Sentry. |
added 6 commits
July 7, 2023 16:35
# Conflicts: # pipeline/batch.go # pipeline/pipeline.go
# Conflicts: # fd/file.d.go # pipeline/batch.go # pipeline/pipeline.go # pipeline/processor.go
HeadHunter483
approved these changes
Aug 3, 2023
added 3 commits
August 25, 2023 15:07
# Conflicts: # plugin/input/http/http.go # plugin/input/journalctl/journalctl.go # plugin/input/journalctl/reader.go
added 3 commits
August 28, 2023 11:39
# Conflicts: # pipeline/pipeline.go # plugin/input/http/http.go
vadimalekseev
approved these changes
Oct 26, 2023
# Conflicts: # pipeline/metrics_holder.go
# Conflicts: # plugin/input/file/file.go # plugin/input/file/provider.go # plugin/output/elasticsearch/elasticsearch.go
vadimalekseev
force-pushed
the
410-metricholder
branch
from
03e5619
to
ea087c0
Compare
* Some performance optimizations * Rename RenameReleaser -> MetricDeleter * Benchmark prometheus.MetricVec * Replace parallel benchmark with the loop * Fix string copy * Add tests for the HeldMetric * Fix naming & build (#569) * Fix naming & build * Rollback comment * Update MetricHolder test --------- Co-authored-by: Yaroslav Kirillov <kirillov.y6@gmail.com>
# Conflicts: # plugin/input/kafka/kafka.go
# Conflicts: # plugin/input/file/file.go # plugin/input/file/provider.go # plugin/input/file/worker_test.go
# Conflicts: # plugin/output/kafka/kafka.go
vano144
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Features:
Fixes #410