Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kafka output SASL #573

Merged
merged 19 commits into from
Jan 25, 2024
Merged

Fix kafka output SASL #573

merged 19 commits into from
Jan 25, 2024

Conversation

kirillov6
Copy link
Collaborator

Description

Fixed kafka output plugin with sasl_mechanism=SCRAM-SHA-256.

Fixes #572

@kirillov6 kirillov6 self-assigned this Jan 19, 2024
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (0542b7a) 70.16% compared to head (a9ad978) 70.63%.
Report is 2 commits behind head on master.

Files Patch % Lines
plugin/output/kafka/kafka.go 78.26% 4 Missing and 1 partial ⚠️
xtls/tls.go 0.00% 2 Missing ⚠️
plugin/action/mask/mask.go 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #573      +/-   ##
==========================================
+ Coverage   70.16%   70.63%   +0.47%     
==========================================
  Files         112      113       +1     
  Lines       11838    11939     +101     
==========================================
+ Hits         8306     8433     +127     
+ Misses       3024     3001      -23     
+ Partials      508      505       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@HeadHunter483 HeadHunter483 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@vadimalekseev vadimalekseev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kirillov6 kirillov6 merged commit 556778f into master Jan 25, 2024
10 checks passed
@kirillov6 kirillov6 deleted the 572-fix-kafka-sasl branch January 25, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: SASL SCRAM-SHA-256 in kafka output plugin
3 participants