Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

598 modify plugin trim filter #599

Merged
merged 5 commits into from
Mar 14, 2024
Merged

Conversation

HeadHunter483
Copy link
Collaborator

Description

Add trim filter to modify plugin. It has three modes: trim all, trim left and trim right. The filter accepts two arguments: mode and a cutset (substring to trim).

Fixes #598

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 87.05882% with 33 lines in your changes are missing coverage. Please review.

Project coverage is 70.84%. Comparing base (8f3cbe4) to head (b93998b).
Report is 2 commits behind head on master.

❗ Current head b93998b differs from pull request most recent head be81b75. Consider uploading reports for the commit be81b75 to get more accurate results

Files Patch % Lines
cfg/substitution/regex_filter.go 78.35% 14 Missing and 7 partials ⚠️
cfg/substitution/trim_filter.go 86.36% 6 Missing and 3 partials ⚠️
cfg/substitution/filter.go 96.73% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #599      +/-   ##
==========================================
+ Coverage   70.64%   70.84%   +0.19%     
==========================================
  Files         119      122       +3     
  Lines       12340    12408      +68     
==========================================
+ Hits         8718     8790      +72     
+ Misses       3110     3108       -2     
+ Partials      512      510       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HeadHunter483 HeadHunter483 merged commit 53e3b5d into master Mar 14, 2024
8 checks passed
@HeadHunter483 HeadHunter483 deleted the 598-modify-plugin-trim-filter branch March 14, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add an ability to trim field value
3 participants