Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auth with client cert in kafka plugin #607

Merged
merged 3 commits into from
Mar 26, 2024
Merged

auth with client cert in kafka plugin #607

merged 3 commits into from
Mar 26, 2024

Conversation

DmitryRomanov
Copy link
Collaborator

@DmitryRomanov DmitryRomanov commented Mar 22, 2024 •
edited

sample of config

pipelines:
  kafka:
    settings:
      capacity: 128
    input:
      type: kafka
      client_cert: /certs/file-d.crt.pem
      client_key: |
        -----BEGIN PRIVATE KEY-----
        ...
        -----END PRIVATE KEY-----
      ca_cert: /certs/ca.pem
      is_ssl_enabled: true
      brokers:
        - 127.0.0.1:9093
      topics:
        - events
      offset: newest
    actions:
    - type: json_decode
      field: message
    output:
      type: stdout

@codecov Codecov
Copy link

codecov bot commented Mar 22, 2024 •
edited

Codecov Report

Attention: Patch coverage is 74.07407% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 70.82%. Comparing base (a810132) to head (41614b6).

Files Patch % Lines
plugin/input/kafka/kafka.go 22.22% 5 Missing and 2 partials ⚠️
plugin/output/kafka/kafka.go 12.50% 5 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #607      +/-   ##
==========================================
+ Coverage   70.78%   70.82%   +0.04%     
==========================================
  Files         123      123              
  Lines       12468    12496      +28     
==========================================
+ Hits         8825     8850      +25     
- Misses       3129     3134       +5     
+ Partials      514      512       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DmitryRomanov DmitryRomanov merged commit 6de60c8 into master Mar 26, 2024
10 checks passed
@DmitryRomanov DmitryRomanov deleted the kafka-auth-client-cert branch March 26, 2024 13:26
DmitryRomanov added a commit that referenced this pull request Mar 26, 2024
@DmitryRomanov
auth with client cert in kafka plugin (#607)
f8b7b4c 
* auth with client cert in kafka plugin

* because you can set content of cert or key

* e2e test for kafka auth by client cert
DmitryRomanov added a commit that referenced this pull request Mar 26, 2024
@DmitryRomanov
auth with client cert in kafka plugin (#607)
7076563 
* auth with client cert in kafka plugin

* because you can set content of cert or key

* e2e test for kafka auth by client cert
DmitryRomanov added a commit that referenced this pull request Mar 27, 2024
@DmitryRomanov
auth with client cert in kafka plugin (#607)
65b153b 
* auth with client cert in kafka plugin

* because you can set content of cert or key

* e2e test for kafka auth by client cert
DmitryRomanov added a commit that referenced this pull request Mar 28, 2024
@DmitryRomanov
auth with client cert in kafka plugin (#607)
92cf169 
* auth with client cert in kafka plugin

* because you can set content of cert or key

* e2e test for kafka auth by client cert
DmitryRomanov added a commit that referenced this pull request Apr 18, 2024
@DmitryRomanov
auth with client cert in kafka plugin (#607)
24a3b07 
* auth with client cert in kafka plugin

* because you can set content of cert or key

* e2e test for kafka auth by client cert
DmitryRomanov added a commit that referenced this pull request May 20, 2024
@DmitryRomanov
auth with client cert in kafka plugin (#607)
9c1dd56 
* auth with client cert in kafka plugin

* because you can set content of cert or key

* e2e test for kafka auth by client cert
DmitryRomanov added a commit that referenced this pull request May 23, 2024
@DmitryRomanov
meta info in pipeline (#600)
e4ace70 
* auth with client cert in kafka plugin (#607)

* auth with client cert in kafka plugin

* because you can set content of cert or key

* e2e test for kafka auth by client cert

* dont skip event on error parse meta

* when template for meta is simple

* fix metadata fillment after review

* rename metadata registry to templater

* add meta in configs for e2e test

* dont reuse buffer in templater for avoid race

* convertToResultMaps returns strings

* Revert "dont reuse buffer in templater for avoid race"

This reverts commit 60db00c.

* poolBuffer in meta templater

* use sync.pool in template if we have templates

* fix flaky TestServeChunks
DmitryRomanov added a commit that referenced this pull request May 23, 2024
@DmitryRomanov
auth with client cert in kafka plugin (#607)
24a8745 
* auth with client cert in kafka plugin

* because you can set content of cert or key

* e2e test for kafka auth by client cert
DmitryRomanov added a commit that referenced this pull request Jun 6, 2024
@DmitryRomanov
auth with client cert in kafka plugin (#607)
7a6a598 
* auth with client cert in kafka plugin

* because you can set content of cert or key

* e2e test for kafka auth by client cert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeadHunter483 HeadHunter483 HeadHunter483 approved these changes

@kirillov6 kirillov6 kirillov6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DmitryRomanov @HeadHunter483 @kirillov6