Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont remove symlink from file provider on broken link #619

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

DmitryRomanov
Copy link
Collaborator

@DmitryRomanov DmitryRomanov commented Apr 24, 2024

don't remove symlink from provider in case of broken link (for example in moment of rotation logs in k8s-plugin)

@DmitryRomanov DmitryRomanov marked this pull request as ready for review April 24, 2024 09:12
@DmitryRomanov DmitryRomanov force-pushed the fix-remove-symlink branch 3 times, most recently from c122773 to 4a68b2d Compare April 24, 2024 09:16
Copy link
Collaborator

@HeadHunter483 HeadHunter483 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DmitryRomanov DmitryRomanov force-pushed the fix-remove-symlink branch 2 times, most recently from 1305721 to 0f7efa7 Compare April 25, 2024 12:03
@DmitryRomanov DmitryRomanov merged commit 953aa11 into master Apr 26, 2024
8 checks passed
@DmitryRomanov DmitryRomanov deleted the fix-remove-symlink branch April 26, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants