remove platform specific plugin configuration & allow to change text height from client code #18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! Thanks for the awesome package for showing lyrics inside Flutter.
Only "plugins" need to have platform specific code for leveraging native functionalities through platform interface.
Since, this "package" only aims to provide non-platform specific UI only code, there is no need to create platform specific configuration with native code for each platform.
This results in unnecessary bundling of shared libraries on all platforms, which isn't even used.
More details may be found at: https://docs.flutter.dev/development/packages-and-plugins/developing-packages#types
I also removed hardcoded
copyWith
calls which change the renderedText
's height to1
. I don't know if this results in some problem, sure let me know.