Document on exception #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-alik
reviewed
Jan 4, 2019
lib/Gearman/Task.pm
Outdated
|
|
||
| A subroutine reference to be invoked when the task fails. The client | ||
| needs to be configured to support exception handling by setting the | ||
| attribute C<exception> to a true value. The subroutine will be passed |
There was a problem hiding this comment.
attribute
C<exception>
The attribute name is exceptions
perl-Gearman/lib/Gearman/Client.pm
Line 71 in 4f221ba
added 4 commits
January 4, 2019 13:15
- with the GEARMAN_SUPPORTS_EXCEPTIONS environment variable
andk
force-pushed
the
document_on_exception
branch
from
e4d57e3
to
a0b1510
Compare
|
Sorry! Amended now and pushed again. |
p-alik
approved these changes
Jan 4, 2019
|
Looks good to me! |
|
Thank you, @andk! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a partial answer to issue #43 and consists of four commits.
Thr first commit tries to find a wording that describes on_exception mechanism. The other three are tiny enhancements on tests.
I hope you like.