This repository has been archived by the owner on Nov 11, 2018. It is now read-only.
Issue #377 collapse button staying red #382
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| last_command = stream_element.get_text_parameter(0, ""); | ||
| else | ||
| last_command = null; | ||
|
|
There was a problem hiding this comment.
I like this solution a lot! There are two changes I would like to see before I merge:
- Please adapt the code style to what is used elsewhere (space after
if, curly braces around blocks) - IMO, if
last_commandisnull,command_executedshould never be invoked, so the invocation should be moved into the first part of theifclause.
|
This looks good now, but I actually just found that we shouldn't even have this problem in the first place as the "preexec" script apparently has functionality to detect empty commands. For some reason, this is not working though (which is the real bug); I'm currently investigating why. |
|
I found the issue underlying the bug and fixed it in 39b078b (explanation in #377 (comment)). I'm closing this PR since it only masks the real problem which is now solved. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically it checks if the current command is not empty. If it's not then the command was actually executed, otherwise last_command is discarded