Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parsing error color. #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alxarsenault
Copy link
Collaborator

Add bold red color on error + "Parsing error : <error_msg>."

@p-groarke
Copy link
Owner

thx! Je sais pas si je vais le rajouter, mais garde le PR ouvert pour l'instant.

Copy link
Owner

@p-groarke p-groarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mini review.

Colors disabled by default.

No ifdefs : Its up to the user to not enable colors on the platforms he is compiling for (Win10 anniversary supports ANSI escapes for example).

Rather than copy-pasting the "Parsing error :" string, create a string in the method and prepend/append the ANSI codes if colors are enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants