Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javascript implementation #47

Closed
ranisalt opened this issue Dec 20, 2015 · 6 comments
Closed

Javascript implementation #47

ranisalt opened this issue Dec 20, 2015 · 6 comments

Comments

@ranisalt
Copy link
Contributor

I've created bindings for Javascript based on this implementation: https://github.com/ranisalt/node-argon2
Currently I didn't implement an option to choose between Argon2i and Argon2d but that's on the way.

@technion
Copy link
Contributor

Surely the reference library isn't going to include a binding for every single language? I'm saying this as someone who wrote a Ruby gem and doesn't expect to see it here.

@veorq
Copy link
Member

veorq commented Dec 21, 2015

Python bindings are part of the codebase so far, but yeah we don't want to include all bindings. The best is probably to leave them all out and provide a link in the README, and/or how to get them using the language's packaging systems.

@technion
Copy link
Contributor

@veorq Would definitely support leaving them all out. Both myself and @ranisalt have elected to directly reference the source repository, which is a good way of guaranteeing there's been no tampering - would recommend all future bindings do the same. It does however, mean the first step of using for Node or Ruby is to download Python code.

@ranisalt Is your binding pushed to npm? Perhaps a PR documenting various language packages into the README is the way to go here.

@ranisalt
Copy link
Contributor Author

@ranisalt Is your binding pushed to npm? Perhaps a PR documenting various language packages into the README is the way to go here.

Yes, that was my point. I do prefer to have a listing of bindings to different languages rather than being merged to this repository. The package is here.

@veorq veorq mentioned this issue Dec 21, 2015
Merged
@technion
Copy link
Contributor

Suggested text...

Bindings

Bindings for popular languages are provided and supported by third parties. For more information, see these links:

Python: https://pypi.python.org/pypi/argon2
JavaScript: https://www.npmjs.com/package/argon2
Ruby: https://github.com/technion/ruby-argon2

@veorq
Copy link
Member

veorq commented Dec 22, 2015

@veorq veorq closed this as completed Dec 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants