Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SBF module, cc_3dmasc .load_sbf_features() and 3DMASC pull request #18

Open
solangejurado opened this issue Feb 27, 2024 · 5 comments
Open

Comments

@solangejurado
Copy link

I'm trying to realize the 3DMASC tutorial
When running cc_3dmasc .load_sbf_features() I have the following error : AttributeError: There is a dedicated module for SBF format handling, use 'from lidar_platform import sbf'.
From looking into your code and the git blame, it seems like the change in the cc file regarding the sbf functions aren’t taken into account into the cc_3dmasc.load_sbf function(). I’ve looked into the 3DMASC pull request and it seems the merging won’t fix this issue either.
Do you have an idea when you’re going to merge the pull request ? Do you plan modifying the load_sbf function() function to use SBF module instead of the cc SBF read/write functions ?
Thank you for your help and work !

@p-leroy
Copy link
Owner

p-leroy commented Feb 27, 2024

I have merged the pull request. Did you try to fix the issue yourself?

@solangejurado
Copy link
Author

Thanks for the merge, no I haven't try to fix the issue.

p-leroy added a commit that referenced this issue Apr 4, 2024
…uest #18

Functions to handle SBF data are in the sbf module now
@p-leroy
Copy link
Owner

p-leroy commented Apr 4, 2024

I have updated the code in cc_3dmasc.py, could you try with this version?

@solangejurado
Copy link
Author

Thanks. I have tried with this version. I just had to changed sbf.read_sbf to sbf.read in file cc_3dmasc.py line 47 for it to work

@p-leroy
Copy link
Owner

p-leroy commented Apr 10, 2024

Good catch, I was working on it this morning with a colleague, I have included the change also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants