Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some cleanup in CPack packaging #115

Merged
merged 1 commit into from
Sep 1, 2021
Merged

Some cleanup in CPack packaging #115

merged 1 commit into from
Sep 1, 2021

Conversation

KOLANICH
Copy link
Contributor

No description provided.

@skrobinson
Copy link
Contributor

I think you're saying there's a duplicate version check and variable definition. Is this correct?

@KOLANICH
Copy link
Contributor Author

KOLANICH commented Aug 17, 2021 •
edited
Loading

I have mistakingly placed this piece of code twice into different places.

@skrobinson
Copy link
Contributor

This looks like a simple fix that should be applied.

@skrobinson
Copy link
Contributor

@p-ranav Bump.

@p-ranav p-ranav merged commit b0cb28a into p-ranav:master Sep 1, 2021
@KOLANICH KOLANICH deleted the cpack branch September 1, 2021 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@KOLANICH @skrobinson @p-ranav