Issue with the CSV header

[amirmasoudabdol]

I'm trying to use the csv::Writer as a backend for my Persistent Manager class but for some reason I cannot get it to write the header. Basically, I have something like this:

class PM {
	class Writer;
}

class Writer{

	using namespace std;

	string filename;
	unique_ptr<csv::Writer> writer;

	Writer(string filename) filename(filename) {
		writer = make_unique<csv::Writer>(filename);
		writer->configure_dialect().delimiter(cols);
	}

	~Write(){
		writer->close();
	}

	void write(map<sting, string> row) {
               // I override the method to accept vector<string> as well.
		writer->configure_dialect().column_names(cols);

		writer->write_row(row);
	}
}

Do you see any particular issue with this? I'm not quite sure why honestly, everything looks fine.

[p-ranav]

I've pushed a fix for this. Can check if it's working now?

[amirmasoudabdol]

That indeed fixes the issue. Thanks. I wonder if you would like the idea of this override for the column_names. I use a simple method like below. You can probably adjust it to fit the code better.

    Dialect& column_names(const std::vector<std::string> &column_names) {
      column_names_ = column_names;
      return *this;
    }

[p-ranav]

I've pushed an update to support this.

#include <csv/writer.hpp>

int main() {
  csv::Writer foo("test.csv");
  foo.configure_dialect()
    .delimiter(", ")
    .column_names(std::vector<std::string>{"a", "b", "c"});
  foo.write_row("1", "2", "3");
  foo.close();
  return 0;
}

Hope this meets your needs.

[amirmasoudabdol]

That would work! 👍🏼