Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After merging audio and video, audio and video stay around #16

Open
Kyle-Mickan opened this issue Jun 10, 2021 · 2 comments
Open

After merging audio and video, audio and video stay around #16

Kyle-Mickan opened this issue Jun 10, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@Kyle-Mickan
Copy link

When download a file that separates audio and video into 2 files after saveddit merges them into 1 file the individual audio and video files stay around. Is this intended functionality? or Can there be an option to only keep the merged file when downloading?

@p-ranav
Copy link
Owner

p-ranav commented Jun 10, 2021

Yeah saveddit right now doesn't delete the individual audio and video files after a successful merge - I figured some might like the video component without audio so I decided against deleting it at the time of development.

I think it can probably be changed to always delete the individual components if the merge is successful.

@p-ranav p-ranav added the enhancement New feature or request label Jun 10, 2021
@NickolaiBeloguzov
Copy link
Contributor

I think it needs to be an option. Like, by default saveddit can keep these files after merging, but if user provides a flag (e.g. --clean or something like this) these files will be deleted. This behaviour could be reversed (deleting by default, keeping if user requests)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants