Make tabulate compatible with mac's SDK 10.9 #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @p-ranav, would you be interested in having this changes merged in your repo? |
|
Hey @marimeireles can you resolve the conflicts? I can test it at my end after the resolution and then merge if everything works OK. |
|
@p-ranav, sure! It's fixed =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our project we have a restriction that doesn't allow us to use a macOS SDK older than 10.9.
The problem is that 10.9 doesn't offer full support to c++ 17 features, so things like
optionalandvariantwon't work well.In order for it to work in 10.9 I had to make some changes, there is no
value()method foroptionaland nogetforvariant, fortunately it's possible to use the equivalents*andget_info, and that's what I'm doing in this PR.