Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compiler warning "non-virtual-dtor" #58

Merged
merged 1 commit into from
Jan 18, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions include/tabulate/asciidoc_exporter.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,8 @@ class AsciiDocExporter : public Exporter {
return ss.str();
}

virtual ~AsciiDocExporter() {}

private:
std::string add_formatted_cell(Cell &cell) const {
std::stringstream ss;
Expand Down
1 change: 1 addition & 0 deletions include/tabulate/exporter.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ namespace tabulate {
class Exporter {
public:
virtual std::string dump(Table &table) = 0;
virtual ~Exporter() {}
};

} // namespace tabulate
2 changes: 2 additions & 0 deletions include/tabulate/latex_exporter.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,8 @@ class LatexExporter : public Exporter {
return result;
}

virtual ~LatexExporter() {}

private:
std::string add_alignment_header(Table &table) {
std::string result{"{"};
Expand Down
2 changes: 2 additions & 0 deletions include/tabulate/markdown_exporter.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@ class MarkdownExporter : public Exporter {
return result;
}

virtual ~MarkdownExporter() {}

private:
void add_alignment_header_row(Table &table) {
auto &rows = table.table_->rows_;
Expand Down
7 changes: 7 additions & 0 deletions single_include/tabulate/tabulate.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -7117,6 +7117,7 @@ namespace tabulate {
class Exporter {
public:
virtual std::string dump(Table &table) = 0;
virtual ~Exporter() {}
};

} // namespace tabulate
Expand Down Expand Up @@ -7168,6 +7169,8 @@ class MarkdownExporter : public Exporter {
return result;
}

virtual ~MarkdownExporter() {}

private:
void add_alignment_header_row(Table &table) {
auto &rows = table.table_->rows_;
Expand Down Expand Up @@ -7354,6 +7357,8 @@ class LatexExporter : public Exporter {
return result;
}

virtual ~LatexExporter() {}

private:
std::string add_alignment_header(Table &table) {
std::string result{"{"};
Expand Down Expand Up @@ -7447,6 +7452,8 @@ class AsciiDocExporter : public Exporter {
return ss.str();
}

virtual ~AsciiDocExporter() {}

private:
std::string add_formatted_cell(Cell &cell) const {
std::stringstream ss;
Expand Down