Edited contents in Palash Nigam's profile #58
Conversation
|
|
||
| BUNDLED WITH | ||
| 1.16.2 | ||
| 1.16.3 |
There was a problem hiding this comment.
@itsmepiyush2 please change it back to 1.16.2 and also don't change anything in this file
|
@knrt10 Sorry I'm still a newbie on GitHub. I did not understand what you said. Can you please elaborate so that I can make necessary changes? |
|
@itsmepiyush2 please follow these steps:-
|
|
After that make a new PR |
why do you want a new PR ? @knrt10 can't he just amend the commit ? I want @itsmepiyush2 to learn amend and force push |
|
Just to make things clear @knrt10 we will always amend commits don't let the juniors take the easy way out 😜 if we train them well here and be strict with our reviews it will be easier for them to contribute to major OSS organizations. |
|
|
||
| - I also like to write articles and have written for opensource.com and geeksforgeeks.org in the past. I also maintain a list of links to all my articles just in case you are interested. | ||
| - Most of my time is spent hacking on open source. I have made contributions to coala, duckduckgo, Kinto, OpenGenus, Mozilla and the Ethereum foundation. Moreover, I am fond of writing articles. I have prior experience in content writing for opensource.com and geeksforgeeks.org. For those interested, I maintain a list of links to all my articles. |
There was a problem hiding this comment.
can you add this as a link to the last word of this point i.e [articles](https://github.com/palash25/articles/) ?
There was a problem hiding this comment.
Could you tell me what the "remote name" is? I'll do a force push.
There was a problem hiding this comment.
Could you please google that first and then ask me if you still don't understand?
There was a problem hiding this comment.
I actually did. I couldn't understand so I asked. Sorry.
There was a problem hiding this comment.
remote_name is the name given to the repository url. Do git remote -v and tell me what you see.
There was a problem hiding this comment.
origin https://github.com/itsmepiyush2/p-society.github.io.git (fetch)
origin https://github.com/itsmepiyush2/p-society.github.io.git (push)
There was a problem hiding this comment.
that means origin is your remote name. You will also need to add an upstream remote but we can do that after this PR. The upstream will point to this repo i.e. p-society/p-society.githu.....
|
@knrt10 this wasn't supposed to be merged yet please read the ongoing conversations before merging stuff. Now if I revert this it shows a that I have authored the commit. How do you plan to fix this? I had also asked @itsmepiyush2 to force push #58 (comment) how is he supposed to do that now? |
|
@knrt10 I need you to fix this mess You should be more careful @knrt10 while reviewing. You didn't even realize that @itsmepiyush2 hasn't pushed the suggested changes yet and the current state of the PR doesn't even address your own review comments. I guess you are drunk with power 😜 since you have had sole control over this repo since the beginning from now on we should require at least 2 approvals before merging any PRs. |
No description provided.