Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Typo #19

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Fix Typo #19

merged 2 commits into from
Jan 16, 2024

Conversation

mlch911
Copy link
Contributor

@mlch911 mlch911 commented Jan 16, 2024

No description provided.

@p-x9
Copy link
Owner

p-x9 commented Jan 16, 2024

Thanks. @mlch911
I think I may need to modify the macro implementation as well to avoid generating unnecessary spaces.

I will take a look at it later.

@p-x9
Copy link
Owner

p-x9 commented Jan 16, 2024

@mlch911
Could you try changing the type to type.trimmed in the following two places?
This is to remove the whitespace specified for trailingTrivia.

AssociatedObject/Sources/AssociatedObjectPlugin/AssociatedObjectMacro.swift

Lines 228 to 230 in ac2684b

TupleTypeElementSyntax(
type: type
)

AssociatedObject/Sources/AssociatedObjectPlugin/AssociatedObjectMacro.swift

Lines 286 to 288 in ac2684b

TupleTypeElementSyntax(
type: type
)

@mlch911
Copy link
Contributor Author

mlch911 commented Jan 16, 2024

done

@p-x9
Copy link
Owner

p-x9 commented Jan 16, 2024

Thanks

@p-x9 p-x9 merged commit da994fc into p-x9:main Jan 16, 2024
1 check passed
@mlch911 mlch911 deleted the fix-typo branch January 16, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mlch911 @p-x9