omit the initial "_" in the symbol name

p-x9 · Feb 5, 2024 · 9ad7d14 · 9ad7d14
1 parent f399928
commit 9ad7d14
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/Sources/FishHook/FishHook.swift b/Sources/FishHook/FishHook.swift
@@ -69,7 +69,7 @@ extension FishHook {
 
         for entry in rebindingsEntry {
             for rebinding in entry.rebindings {
-                guard rebinding.name.withCString({ strcmp($0, symbol.nameC) == 0 }) else { continue }
+                guard rebinding.name.withCString({ strcmp($0, symbol.nameC + 1) == 0 }) else { continue }
 
                 let ptr = UnsafeMutableRawPointer(mutating: machO.ptr.advanced(by: symbol.offset))
                 if rebinding.replaced == nil && rebinding.replacement != ptr {

diff --git a/Tests/FishHookTests/FishHookTests.swift b/Tests/FishHookTests/FishHookTests.swift
@@ -13,14 +13,14 @@ final class FishHookTests: XCTestCase {
 
         guard let machO = MachOImage(name: "FishHookTests") else { return }
         guard let to = machO.symbol(
-            named: "_$s13FishHookTests25XXXXhook_assertionFailure__4file4line5flagss5NeverOs12StaticStringV_A2ISus6UInt32VtF"
+            named: "$s13FishHookTests25XXXXhook_assertionFailure__4file4line5flagss5NeverOs12StaticStringV_A2ISus6UInt32VtF"
         ) else {
             return
         }
 
         let rebindings: [Rebinding] = [
             .init(
-                name: "_$ss17_assertionFailure__4file4line5flagss5NeverOs12StaticStringV_A2HSus6UInt32VtF",
+                name: "$ss17_assertionFailure__4file4line5flagss5NeverOs12StaticStringV_A2HSus6UInt32VtF",
                 replacement: .init(mutating: machO.ptr.advanced(by: to.offset)),
                 replaced: nil
             )