[enhancement] Display comment field in output

[CaledoniaProject]

Please add the comment field to your output. Currently only the folder name and server name is displayed.

[p0dalirius]

The share comments are included in the structure _SHARE_INFO_1 returned by smbClient.listShares() :

typedef struct _SHARE_INFO_1 {
  LMSTR shi1_netname;
  DWORD shi1_type;
  LMSTR shi1_remark;
} SHARE_INFO_1, *PSHARE_INFO_1, *LPSHARE_INFO_1;

It's now added into FindUncommonShares.py:

FindUncommonShares/FindUncommonShares.py

Lines 380 to 384 in 557054a

	# SHARE_INFO_1 structure (lmshare.h)
	# https://docs.microsoft.com/en-us/windows/win32/api/lmshare/ns-lmshare-share_info_1
	sharename = share['shi1_netname'][:-1]
	sharecomment = share['shi1_remark'][:-1]
	sharetype = share['shi1_type']

I also added the share flags in the exported JSON data.

{
  "sharename": "AnotherShare",
  "uncpath": "\\\\192.168.2.11\\AnotherShare\\",
  "computer": "PC01.LAB.local",
  "comment": "",
  "type": {
    "stype_value": 0,
    "stype_flags": [
      "STYPE_DISKTREE",
      "STYPE_SPECIAL",
      "STYPE_TEMPORARY"
    ]
  }
}

References

• https://docs.microsoft.com/en-us/windows/win32/api/lmshare/ns-lmshare-share_info_1