Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test Initial translation (arabic-العربية) #766

Merged
merged 7 commits into from
Apr 22, 2024

Conversation

columbusux
Copy link
Contributor

pls test i haven't slept for two days...

@p0deje
Copy link
Owner

p0deje commented Apr 20, 2024

pls test i haven't slept for two days...

Thank you, I'll test. You better get some sleep 😴

@p0deje
Copy link
Owner

p0deje commented Apr 20, 2024

Looking through PR, I would ask you to revert the conversion to Maccy/Localizable.xcstrings. It's a format that Xcode recommends, but it's not supported by the BartyCrouch tool that is used, so I'm holding off from this migration.

I can undo the change myself with some Vim macros though.

@p0deje
Copy link
Owner

p0deje commented Apr 20, 2024

Thank you for the PR, please see my review below!

Main window

‏لقطة الشاشة ٢٠٢٤-٠٤-٢٠ في ٠٨ ٣١ ٥١

Everything is translated except for the "Preview" popup. Can you add translations to Maccy/Menu/Preview/ar.lproj/Preview.strings?

General preferences

‏لقطة الشاشة ٢٠٢٤-٠٤-٢٠ في ٠٨ ٣١ ٥٨

Everything is great with a small exception to the layout of hotkeys controls. I'll fix that myself, you don't have to do anything.

Appearance preferences

‏لقطة الشاشة ٢٠٢٤-٠٤-٢٠ في ٠٨ ٤٦ ٢٤

There are some missing translations, can you add them to Maccy/Settings/ar.lproj/AppearanceSettingsViewController.strings?

Others

The rest looks great, please see some screenshots:

‏لقطة الشاشة ٢٠٢٤-٠٤-٢٠ في ٠٨ ٣٢ ٠٠ ‏لقطة الشاشة ٢٠٢٤-٠٤-٢٠ في ٠٨ ٣٢ ١٩ ‏لقطة الشاشة ٢٠٢٤-٠٤-٢٠ في ٠٨ ٣٢ ٢٦ ‏لقطة الشاشة ٢٠٢٤-٠٤-٢٠ في ٠٨ ٥٢ ٢٨

@columbusux
Copy link
Contributor Author

Thank you for the review, and I apologize. I think I made some mistakes unintentionally. I wasn’t fully focused at the time. Don’t worry, I will do that after I’m free. 🫡
Thanks again brother.

@MohammedEssehemy
Copy link

Thank you @columbusux for adding the Arabic translation 🙏🏻

columbusux and others added 2 commits April 21, 2024 20:59
    * Improved the Arabic language support for better readability and user experience.
- تحسينات اللغة العربية
    * تم تحسين دعم اللغة العربية لتحسين قابلية القراءة وتجربة المستخدم.
@p0deje
Copy link
Owner

p0deje commented Apr 21, 2024

Looks great, I'm ready to merge it if you consider it complete.

@columbusux
Copy link
Contributor Author

Yes, you good to go.
It was an honor for me to help and work with you. I wish you success brother. ♥️

@p0deje p0deje merged commit a4ed69f into p0deje:master Apr 22, 2024
1 check passed
@p0deje
Copy link
Owner

p0deje commented Apr 22, 2024

Thank you once again, all the best to you too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants