Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebirth doesn't clear old job quests which prevents players from being the same job again #34

Closed
4 tasks
wejrox opened this issue May 18, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@wejrox
Copy link

wejrox commented May 18, 2021

Second job quests for explorers use custom quest IDs for tracking the progress (letter, marbles, proof of hero). When rebirthing, these quests are still marked as completed for the player, which prevents them from getting past the letter phase.

The custom quest IDs are not shorts either, although they need to be in order to send the packet to the client.
In order to set up the rebirth to reset completed class-specific quests, the custom quests will need to have their id changed to be < 32767 in order to be a short, and the rebirth system will need to be extended to forfeit those quests. Currently, no method exists on the maple character to do so.

  • Change custom explorer second job quest ids to be shorts instead of ints
  • Add a method to lazily delete/forfeit quests to the maple character
  • Figure out the list of quests that need to be forfeited for each class and create a reference to them
  • Extend MapleCharacter::rebirth to also forfeit any job-specific quests
@P0nk P0nk added the bug Something isn't working label May 23, 2021
@P0nk
Copy link
Owner

P0nk commented Jul 19, 2024

No longer relevant as rebirth system has been removed.

@P0nk P0nk closed this as completed Jul 19, 2024
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants