Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract-jks: Prefer _p11_extract_jks_timestamp to SOURCE_DATE_EPOCH #213

Merged
merged 1 commit into from Jan 29, 2019

Conversation

ueno
Copy link
Member

@ueno ueno commented Jan 28, 2019

Give _p11_extract_jks_timestamp precedence over SOURCE_DATE_EPOCH so
that the test results are not affected by the envvar settings.

Fixes #212

Give _p11_extract_jks_timestamp precedence over SOURCE_DATE_EPOCH so
that the test results are not affected by the envvar settings.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 80.334% when pulling c0a394d on ueno:wip/dueno/jks-timestamp into 1ba80c6 on p11-glue:master.

@ueno
Copy link
Member Author

ueno commented Jan 28, 2019

@heftig, @ametzler, @haraldh do you think this change is okay?

@ametzler
Copy link

Works for me, thanks.

@heftig
Copy link
Contributor

heftig commented Jan 28, 2019

WFM, too. Thanks.

@ueno ueno merged commit 2a474e1 into p11-glue:master Jan 29, 2019
@ueno ueno added the bug label May 22, 2019
@ueno ueno added this to the 0.23.16 milestone May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jks tests fail if SOURCE_DATE_EPOCH is set
4 participants