rpc: Add missing null checks in attribute value serializers #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
|
This would fix a long standing issue =) friendly ping |
|
Sorry, I realized that this alone doesn't fix the mentioned RHBZ bug, which may require support in Firefox side. Yet the change itself should be correct. |
To get the length of an attribute value, the client calls C_GetAttributeValue with attr->pValue set to NULL and attr->ulValueLen set to -1. In the RPC level, this is already indicated with a 'validity' flag, but there were a couple of places where attr->pValue is non-NULL. This was uncovered by: https://bugzilla.redhat.com/show_bug.cgi?id=1766340
ueno
force-pushed
the
wip/dueno/value-null
branch
from
ba1b21c
to
e60d965
Compare
|
Thanks for the review (merged after rewording the commit message). |
|
Hey @ueno @t8m - Is there anything tracking the remaining work mentioned in #279 (comment) ? xref: https://bugzilla.redhat.com/show_bug.cgi?id=1766340#c11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To get the length of an attribute value, the client calls
C_GetAttributeValuewithattr->pValueset toNULLandattr->ulValueLenset to -1. In the RPC level, this is already indicated with a'validity' flag, but there were a couple of places that assume
attr->pValueis non-NULL.This was uncovered by:
https://bugzilla.redhat.com/show_bug.cgi?id=1766340