Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gtkdoc: remove dependencies on custom target files #407

Merged
merged 1 commit into from
Jan 12, 2022
Merged

gtkdoc: remove dependencies on custom target files #407

merged 1 commit into from
Jan 12, 2022

Commits on Jan 12, 2022

  1. gtkdoc: remove dependencies on custom target files

    Sadly, the `dependencies` kwarg does not actually do what it seems to be
    trying to be used for, here. It is for listing dependency or library
    objects whose compiler flags should be added to gtkdoc-scangobj.
    
    It will not actually add ninja target dependencies. The similar kwarg in
    other meson functions (e.g. genmarshal and compile_schemas) that *do*
    allow adding target dependencies, is `depend_files`.
    
    Older versions of meson simply did nothing in an if/elif/elif block
    where these custom_targets never matched anything, and were thus
    silently ignored.
    
    Meson 0.61 type-validates the arguments and rejects CustomTarget as
    invalid:
    
    ```
    doc/manual/meson.build:72:8: ERROR: gnome.gtkdoc keyword argument 'dependencies' was of type array[CustomTarget | PkgConfigDependency] but should have been array[Dependency | SharedLibrary | StaticLibrary]
    ```
    
    Fixes #406
    eli-schwartz committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    18c5f0f View commit details
    Browse the repository at this point in the history