Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: simdpp/types/empty_expr.h: c++17 compilation fix #142

Closed
wants to merge 1 commit into from

Conversation

michalfapso
Copy link
Contributor

Compiling with gcc -std=c++17 gave an error message.

@p12tic
Copy link
Owner

p12tic commented Jan 30, 2020

Thanks, and sorry for the delay in reviewing. I've merged #141 which fixes this same issue.

@p12tic p12tic closed this Jan 30, 2020
@peabody-korg
Copy link
Contributor

would it be possible to merge this into the dev branch and/or synchronize the dev and master branches?

@peabody-korg
Copy link
Contributor

peabody-korg commented Mar 22, 2022

also I get the same error in simdpp/types/generic.h xcode 13.2 at line:

simdpp/types/generic.h:244:52: No viable conversion from returned value of type 'mask_int32<4U>' to function return type 'uint32<4U>'

SIMDPP_INL operator uint32<N>() const { return eval(); }

The above pull request does not fix that. casting the result with uint32<N>(eval()) appears to resolve the issue.

@peabody-korg
Copy link
Contributor

peabody-korg commented Mar 23, 2022

there's at least one additional error in empty_expr.h as well. class mask_int64<N, expr_empty> has a similar issue, and the cast solution also appears to resolve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants