Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #124: Checking "additionalProperties" in "oneOf" items. #125

Merged
merged 3 commits into from Mar 26, 2019

Conversation

diogobaeder
Copy link

This is important because it does the correct validation over items that
are restricted in "oneOf", so that it's possible to use schemas that are
superset of one another as items of "oneOf".

…ems.

This is important because it does the correct validation over items that
are restricted in "oneOf", so that it's possible to use schemas that are
superset of one another as items of "oneOf".
@diogobaeder
Copy link
Author

Oops, seems to have failed on Python 2.7 for some reason. I'll fix that.

@codecov
Copy link

codecov bot commented Mar 26, 2019

Codecov Report

Merging #125 into master will decrease coverage by 0.26%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #125      +/-   ##
==========================================
- Coverage   96.32%   96.05%   -0.27%     
==========================================
  Files          54       54              
  Lines        1470     1472       +2     
==========================================
- Hits         1416     1414       -2     
- Misses         54       58       +4
Impacted Files Coverage Δ
openapi_core/schema/schemas/models.py 95.18% <100%> (+0.02%) ⬆️
openapi_core/compat.py 55.55% <0%> (-44.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f7c6ba...14196b6. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 26, 2019

Codecov Report

Merging #125 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #125      +/-   ##
==========================================
+ Coverage   96.32%   96.33%   +<.01%     
==========================================
  Files          54       54              
  Lines        1470     1474       +4     
==========================================
+ Hits         1416     1420       +4     
  Misses         54       54
Impacted Files Coverage Δ
openapi_core/schema/schemas/models.py 95.2% <100%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f7c6ba...4d99cbe. Read the comment docs.

@p1c2u
Copy link
Collaborator

p1c2u commented Mar 26, 2019

@diogobaeder thank you for the contribution. Made small refactor. LGTM

@p1c2u p1c2u merged commit f274836 into python-openapi:master Mar 26, 2019
@diogobaeder
Copy link
Author

Thanks, man! Since I'm still new to contributing, I didn't want to do too many changes... so thanks for refactoring it afterwards :-)

@diogobaeder
Copy link
Author

Sorry for commenting here again, but is there any intention of releasing this fix soon?

bjmc pushed a commit to bjmc/openapi-core that referenced this pull request Jun 12, 2019
Fix python-openapi#124: Checking "additionalProperties" in "oneOf" items.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants