quick fix (!important keyword support for color)

p1ho · Dec 18, 2019 · 9ef47fb · 9ef47fb
1 parent 7dfcae2
commit 9ef47fb
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 5 deletions.
diff --git a/src/ColorContrast/Checker.php b/src/ColorContrast/Checker.php
@@ -658,7 +658,9 @@ private function _get_style_properties(string $style_str, string $tag_name, $par
 
         if (isset($styles_raw[$property])) {
             $value = $styles_raw[$property];
-
+            if (strpos($value, '!important') !== false) {
+                $value = trim(str_replace('!important', '', $value));
+            }
             if ($this->_is_color_function($value)) {
                 $child_color_array = $this->_color_function_to_array($value);
                 $this->parent_true_font_color = $child_color_array;

diff --git a/tests/ColorContrast/CheckerTestcases/testcases_basic_html_pass.php b/tests/ColorContrast/CheckerTestcases/testcases_basic_html_pass.php
@@ -104,10 +104,16 @@
     // !important keyword should still be acceptable
     new testcase(
         '
-      <p style="background-color: white !important;">should pass</p>
-      <p style="background-color: rgb(255, 255, 255) !important;">should pass</p>
-      <p style="background-color: rgba(255, 255, 255, .8) !important;">should pass</p>
-      <p style="background-color: #fff !important;">large text should pass</p>
+      <p style="background-color: white !important; color: black !important;">should pass</p>
+      <p style="background-color: rgb(255, 255, 255) !important; color: rgb(0, 0, 0) !important;">should pass</p>
+      <p style="background-color: rgba(255, 255, 255, .8) !important; color: rgba(0, 0, 0, 1) !important;">should pass</p>
+      <p style="background-color: #fff !important; color: #000 !important;">should pass</p>
+      <p style="background-color: transparent !important; color: initial !important;">should pass</p>
+      <p style="background: white !important;">should pass</p>
+      <p style="background: rgb(255, 255, 255) !important;">should pass</p>
+      <p style="background: rgba(255, 255, 255, .8) !important;">should pass</p>
+      <p style="background: #fff !important;">should pass</p>
+      <p style="background: transparent !important;">should pass</p>
       ',
         array('passed'=>true,'errors'=>array())
     ),