Upgrade the forked Home IdP extension to latest commit #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
I've just realised I didn't check to see if there was a diff in any of the template resources or messages. Will try push an update today. |
…test commit 04b9becfb37df63784559c936f0b49609686439e
…-orgs functionality
phamann
force-pushed
the
phamann/upgrade-home-idp
branch
from
323cb06
to
4cb622f
Compare
|
Have now, pushed template changes 👍🏻 |
xgp
approved these changes
Sep 8, 2023
|
@phamann Everything looks good. I'd eventually like to figure out a way to test this, but I don't yet have a good way of testing frontend flows like this. I ran some manual tests on the branch locally, and I see no regressions. |
xgp
reviewed
Sep 8, 2023
src/main/java/io/phasetwo/service/auth/idp/HomeIdpDiscoveryAuthenticatorFactory.java
Show resolved
Hide resolved
xgp
requested changes
Sep 8, 2023
|
@xgp sorry for the delay here. I've now fixed the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Upgrades the forked version of https://github.com/sventorben/keycloak-home-idp-discovery embded within the projects source to the latest commit and then re-applies the nesscary keycloak-orgs patches ontop.
The main driving factor is to pickup improvements in the extension since we forked and take advantge of new configuration parameters.
Notes for reviewers
To help with the review I've isolated the custom p2-inc/keycloak-org changes to the extension in the second commit
323cb064cb622fcloses #83