SFSafariViewController not implemented

[kabiroberai]

I'm not too sure where to ask this (GitHub repositories don't really have feature request pages), but is it possible to add SFSafariViewController to this framework? Now that we can submit iOS 9 apps, I'm sure that it would be a much better user experience.

[p2]

You're in the right spot for "feature requests", I'm flagging this as an enhancement.

[HerbstLukas]

This would be so awesome! :) +1

[nickvelloff]

👍 💥 🙌

[p2]

Implemented on the master branch; iOS 9 will now automatically use SFSafariViewController when using embedded authorization. Let me know how this works for you!

[kabiroberai]

@p2 thanks! I'm having one problem though, I updated the repository, but for some reason calling authorise() now gives me a blank white view. Here is the code I'm using -
oauth2 = OAuth2ImplicitGrant(settings: settings)
oauth2.blog = currLogbook
oauth2.authConfig.authorizeEmbedded = true
oauth2.authConfig.authorizeContext = self
oauth2.onAuthorize = {params in
self.getPosts()
}
oauth2.authorize(params: ["blog":currLogbook], autoDismiss: true)

[p2]

Is this from inside a UIViewController? What is oauth2.blog?

I should also mention that now one needs to intercept the callback in the app delegate, see here:
https://github.com/p2/OAuth2#3-authorize-the-user

[kabiroberai]

@p2 blog is an extra parameter I wanted to pass (I'm using wordpress authentication)

[kabiroberai]

Also, the UIViewController is a modally presented viewcontroller with a navigation controller as its parent

[p2]

Does it work correctly if you set oauth2.authConfig.ui.useSafariView = false?

[kabiroberai]

@p2 yeah, it does. Btw I was using the OS browser before so i have already implemented openURL

[p2]

You need to be more specific. Does it now show the old built-in web view? Is there an error logging when using the Safari view? What can you see when you use Xcode's view debugging? Goes the view blank just like that or is a white view presented? ...

[kabiroberai]

@p2 It shows a completely white screen, throwing absolutely no errors. Also, although the view is a master split screen view controller, even on the iPad it shows in fullscreen mode.

[kabiroberai]

@p2 wait... so it doesn't seem to be OAuth2's fault, I even tried loading a regular SFSafariViewController and it showed up blank

[p2]

Hmmm interesting. SFSafariWebView works on my Xcode GM install, I'm not sure what could cause this.

Yeah the fullscreen thing might be something that not everybody wants, certainly not on iPad.

[kabiroberai]

@p2 it could be because of the UISplitViewController I suppose

[kabiroberai]

@p2 I figured it out. Apparently SFSafariViewController (or any view controller actually) does not like to be presented before the view appears. I was attempting to do it in viewDidLoad, but when it is called, I don't think the view is in the hierarchy yet.

[p2]

Yes, use the appear methods for that.